Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPPL-2654 Merge RPPL-2593 changes to 1.13 #661

Merged
merged 1 commit into from
Oct 18, 2024
Merged

RPPL-2654 Merge RPPL-2593 changes to 1.13 #661

merged 1 commit into from
Oct 18, 2024

Conversation

sakshihcst
Copy link
Contributor

…… (#660)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (… (#657)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (#656)

  • fix: implement rpc_overriddes

  • build: cleanup

  • build: cleanup

  • fix: remove algorithm

  • build: cleanup

  • fix: cleanup device.uid after implementing legacy.device.uid in badger

  • fix: clippy errors

  • build: cleanup

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@sakshihcst @SKumarMetro
RPPL-2593 Device.uid is returning a value that contains dash (#633) (… (
8eedd0c 
#660)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (… (#657)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (#656)

* fix: implement rpc_overriddes

* build: cleanup

* build: cleanup

* fix: remove algorithm

* build: cleanup

* fix: cleanup device.uid after implementing legacy.device.uid in badger

* fix: clippy errors

* build: cleanup

Co-authored-by: Suresh <[email protected]>
@sakshihcst sakshihcst requested review from a team October 17, 2024 20:43
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
core.main.src.bootstrap.manifest 0% ❌
core.main.src.service 31% ❌
device.thunder.src.bootstrap 0% ❌
core.sdk.src.extn 83% ✔
core.main.src.service.apps 47% ➖
core.sdk.src.utils 53% ➖
device.thunder_ripple_sdk.src.client 74% ➖
core.tdk.src.utils 0% ❌
core.main.src.processor.storage 0% ❌
core.sdk.src.api.firebolt 77% ✔
device.thunder_ripple_sdk.src.events 4% ❌
core.sdk.src.api.distributor 84% ✔
device.thunder.src 0% ❌
device.thunder_ripple_sdk.src.processors.events 0% ❌
core.main.src.state 26% ❌
core.sdk.src.framework 75% ➖
core.main.src.firebolt.handlers 8% ❌
core.tdk.src.gateway 100% ✔
core.main.src.broker 43% ➖
openrpc_validator.src 90% ✔
core.main.src.broker.thunder 54% ➖
core.main.src.processor 0% ❌
core.main.src.bootstrap 0% ❌
core.sdk.src.api.gateway 85% ✔
distributor.general.src 2% ❌
core.sdk.src.extn.client 91% ✔
core.launcher.src.manager 7% ❌
core.sdk.src.api.manifest 91% ✔
device.mock_device.src 52% ➖
core.launcher.src 0% ❌
core.sdk.src.api 78% ✔
core.main.src.utils 27% ❌
device.thunder_ripple_sdk.src.bootstrap 0% ❌
core.sdk.src.api.observability 68% ➖
core.main.src.bootstrap.extn 0% ❌
core.sdk.src.api.device 77% ✔
core.main.src.service.extn 40% ❌
device.thunder_ripple_sdk.src.processors 10% ❌
core.main.src.firebolt 4% ❌
core.main.src.state.cap 43% ➖
core.sdk.src.extn.ffi 80% ✔
device.thunder_ripple_sdk.src 15% ❌
core.main.src 0% ❌
Summary 44% (17998 / 41211) ➖

Minimum allowed line rate is 42%

@sakshihcst sakshihcst merged commit 1c513a7 into 1.13.rc Oct 18, 2024
7 checks passed
@sakshihcst sakshihcst deleted the 1.13.rppl.2654 branch October 18, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhillomk dhillomk dhillomk approved these changes

@B-Larsen B-Larsen B-Larsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakshihcst @dhillomk @B-Larsen